https://bugzilla.redhat.com/show_bug.cgi?id=1998497 --- Comment #2 from Erico Nunes <ernunes@xxxxxxxxxx> --- Thank you for the review. (In reply to Artur Frenszek-Iwicki from comment #1) > > %description > > Example KMS/GBM/EGL application > Please don't just repeat the summary here. The description you gave here in > the ticket ("kmscube is [...] minimal working state") would be good enough. I switched it to use the description from the project readme which I think is a little better than the one I made up: https://gitlab.freedesktop.org/mesa/kmscube/-/raw/master/README.md > > Requires: libdrm libpng > Is this needed? I think rpm should pick these up on its own if the binary > actually links to these. (Well, unless it loads them dynamically at runtime.) It turns out that all of the dependencies for this package are picked automatically from the linked libraries, so indeed no explicit Requires are needed here. I rebuilt and retested the package and it still pulls all the same dependencies this way. I pushed the reviewed spec to https://gitlab.com/enunes/kmscube-spec/-/raw/master/kmscube.spec . -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
