https://bugzilla.redhat.com/show_bug.cgi?id=2001232 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thanks for the review! > - No harm including the desktop file for the cli, but I wonder if it needs a "Terminal=true" line there for it to run correctly. https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html You know, I tried actually using the desktop file, and I think it’s pointless. I just hadn’t returned to this review bug to say so. The CLI just prints an error message and exits promptly. So I’m just going to add a comment and default-disable that build conditional. (It actually already has “Terminal=true”; see https://github.com/FastTrackOrg/FastTrack/blob/ff38162/sh.fasttrack.fasttrackcli.desktop#L11.) > - Do we want to generate the manual pdf? I see this in the build log: > + pandoc ../../user_manual/user_manual.html -o ../../user_manual/user_manual.pdf > pdflatex not found. Please select a different --pdf-engine or install pdflatex Yes, thanks! That’s an oversight, as you can tell from the fact that I did already BR pandoc and librsvg2-tools. I’ll add the missing BR on tex(latex). To guard against it disappearing again in the future, I’ll either change the files list to be more explicit, or possibly add --fail-if-warnings to the pandoc invocation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
