https://bugzilla.redhat.com/show_bug.cgi?id=2001378 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > License: GPLv2+ The README mentions some graphics which are under different licences, namely CC0, CC-BY-3.0 and (CC-BY-3.0 or GPLv3). These should also be included here. > BuildRequires: gcc-c++ Is this correct? Looking at the source, it's C, not C++. Since gcc-c++ pulls in gcc, the RPM builds fine, but the point stands. > files > %{_datadir}/icons/hicolor/*/apps/inertiablast.png > %{_metainfodir}/%{name}.metainfo.xml The list of files mixes "inertiablast" and "%{name}". Please choose one and stick to it. Also, the upstream source archive contains a man page, which is not included in the RPM (possibly because CMakeLists.txt doesn't specify it as a file to be installed). Consider manually copying it into the buildroot. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
