[Bug 2000598] Review Request: python-pathos - Parallel graph management and execution in heterogeneous computing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2000598



--- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #3)
> > export PYTHONPATH="$PYTHONPATH:%{python3_sitearch}:%{python3_sitelib}"
> 
> Just curious: Why is this used in %check? Should it include
> %{buidlroot}%{python3_sitearch/lib} instead?

Aha, I've missed the %{buildroot} bit there. Correcting that now. `export
PYTHONPATH="."` also works since it finds the built copy. So does `export
PYTHONPATH=":"`---does a colon at the start ":" mean cwd? Maybe that's why my
wrong command worked? 

Anyway, I'm using the full buildroot/ path now so it finds the installed copy.

(In reply to Miro Hrončok from comment #4)
> Nitpicks:
> 
> - rm -rf %{pypi_name}.egg-info is not needed with pyproject RPM macros.
> - %{python3} is prefered over %{__python3}

Thanks, corrected.

Updated spec/srpm:

Spec URL: https://ankursinha.fedorapeople.org/python-pathos/python-pathos.spec
SRPM URL:
https://ankursinha.fedorapeople.org/python-pathos/python-pathos-0.2.8-1.fc34.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux