https://bugzilla.redhat.com/show_bug.cgi?id=2000347 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: 1. There is no %check section. Having a check section is mandatory in new Python guidelines. If upstream has no tests suite, at least run %py3_check_import mkdocs_redirects to assert the module is importable. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#py3_check_import But I see tests in the upstream repo. 2. There seems to be no %license. I suggest asking upstream to tag the 1.0.3 release, so we can use the git tarball and have the tests and the license file as neither is in the sdists on PyPI. If you do talk to upstream, also suggest they add license_files=['LICENSE'] to their setup.py. Other than that, the specfile seems sane. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
