https://bugzilla.redhat.com/show_bug.cgi?id=1997378 --- Comment #6 from Michal Schorm <mschorm@xxxxxxxxxx> --- I'd still make the %files section more clear to catch possible unexpected changes in the future. Instead of: --- %files %{_bindir}/pg_autoctl %{_libdir}/pgsql %{_datadir}/pgsql %{_mandir}/man1/* %{_mandir}/man5/* %license LICENSE --- I suggest: --- %files %{_bindir}/pg_autoctl %dir %{_libdir}/pgsql %{_libdir}/pgsql/pgautofailover.so %{_libdir}/pgsql/bitcode %dir %{_datadir}/pgsql %dir %{_datadir}/pgsql/extension %{_datadir}/pgsql/extension/pgautofailover--*.sql %{_datadir}/pgsql/extension/pgautofailover.control %{_mandir}/man{1,5}/*.gz %license LICENSE --- ====================== I googled whether this package has already been packed by anyone to seek inspiration and avoid re-inventing the wheel. I found that Devrim Gündüz <devrim@xxxxxxxxxx> is a maintainer of this package in CentOS 7 and he is keeping it up-to-date. https://centos.pkgs.org/7/postgresql-13-x86_64/pg_auto_failover_13-1.6.1-2.rhel7.x86_64.rpm.html He moved the bytecode to a separate package, with a single purpose of JIT. That sounds like a good idea to me. Though I would like first to be sure it is possible to use the JIT files in Fedora in the first place. I don't see a point in packing files without purpose. Please: 1/ examine if and how can be those JIT files used in Fedora 2/ move them to a separate sub-package, remove them entirely, or make a different decision; leave comment in the SPECfile in any case. You may even try to reach Devrim and ask him, so the package maintenance efforts can be coordinated. Please, also take a look at the: "PG_CONFIG=%{pginstdir}/bin/pg_config" variable definition before "make" and "make install" commands and find out whether they are useful in our case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
