[Bug 1993535] Review Request: auditwheel - Cross-distribution Linux wheels auditing and relabeling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1993535



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> The package does not work due to an undeclared dependency on setuptools

Fixed by:

# There is an undeclared dependency on setuptools/pkg_resources,
# once https://github.com/pypa/auditwheel/pull/307 is released, this can be
removed
grep 'import pkg_resources' auditwheel/main.py  # make sure this is still
relevant
echo setuptools >> requirements.txt


> Do you want to check the bundled wheel version?

Done in check via:

# Assert the bundled wheel version
export PYTHONPATH=%{buildroot}%{python3_sitelib}
test "$(%{python3} -c 'from auditwheel._vendor import wheel;
print(wheel.__version__)')" == "%{wheel_version}"


> Should tests be packaged separately?

I don't see them packaged:

$ rpm -qlp
/var/lib/mock/fedora-rawhide-x86_64/result/auditwheel-4.0.0-1.fc36.noarch.rpm |
grep test
(empty)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux