https://bugzilla.redhat.com/show_bug.cgi?id=1999328 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Devel-MAT-Dumper-0.42-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(POSIX) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Devel-MAT-Dumper-0.42-1.fc36.x86_64.rpm | sort | uniq -c 1 perl(Devel::MAT::Dumper) = 0.42 1 perl-Devel-MAT-Dumper = 0.42-1.fc36 1 perl(Devel::MAT::Dumper::Helper) = 0.42 1 perl-Devel-MAT-Dumper(x86-64) = 0.42-1.fc36 Binary provides are Ok. $ rpmlint ./perl-Devel-MAT-Dumper* perl-Devel-MAT-Dumper.src: W: spelling-error %description -l en_US Dumpfile -> Dump file, Dump-file, Dumpling perl-Devel-MAT-Dumper.x86_64: W: spelling-error %description -l en_US Dumpfile -> Dump file, Dump-file, Dumpling perl-Devel-MAT-Dumper.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Devel/MAT/Dumper/Dumper.bs 2 packages and 1 specfiles checked; 1 errors, 2 warnings. FIX: *.bs file should be removed in section %install find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -delete BuildRequires are almost ok FIX: Please add perl-devel and gcc, because it is XS package Please correct all 'FIX' items. Otherwise the package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
