[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1988952

Petr Menšík <pemensik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Petr Menšík <pemensik@xxxxxxxxxx> ---
Did you know %doc would copy files from source directory? Installing them to
correct locations is not necessary.

%doc readme.txt

If would include after %cmake_install:

rm -f %{buildroot}%{_datadir}/%{name}/license.txt

Then remove from %files:
%doc %{_datadir}/%{name}/license.txt

It is handled by %license license.txt already, but put into different
directory. One license copy in a package is enough.

But that is just cosmetic issue. It seems fine and ready for the distribution,
thank you!

Continue by fedpkg request-repo


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux