https://bugzilla.redhat.com/show_bug.cgi?id=1497482 --- Comment #16 from Petr Menšík <pemensik@xxxxxxxxxx> --- Great, Thank you! Would you like to prepare initial spec commit by PR? I have found small issue in existing spec. It includes only contents of directories %{python3_sitelib}/%{name}/*, %{python3_sitelib}/%{name}-%{version}-*.egg-info/* and %{_datadir}/%{name}/*. It should include also the directory itself. Should be just: %{python3_sitelib}/%{name} %{python3_sitelib}/%{name}-%{version}-*.egg-info %{_datadir}/%{name} That is to prevent leaving there unowned directories. They can be checked by rpm -qf: # rpm -qf /usr/share/dnsviz/ file /usr/share/dnsviz is not owned by any package # rpm -qf /usr/share/dnsviz/css dnsviz-0.9.3-1.fc36.noarch Problem with those is when the package is uninstalled, empty unowned directories are not removed, but they should. Consider leaving just trailing slash at the end of name, but without asterisk. As for tests, sure, I have noticed there are some. It would be great if they could be run during build. They must not require connectivity to the internet however. You can test self-contained builds by: # fedpkg --release rawhide mockbuild Which builds it the same way as production builders. Inside mock, without connectivity. They would also lack root access during build, only unprivileged ports are permitted. If those tests can run under such environment, they SHOULD be used. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
