https://bugzilla.redhat.com/show_bug.cgi?id=1998821 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Till Maas <opensource@xxxxxxxxx> --- Thank you, here are some initial observations: FT2 seems to be using non-free bitmaps according to the git repo: https://github.com/8bitbubsy/ft2-clone/blob/master/src/gfxdata/bmp/LICENSE.txt These cannot be included as documented in https://fedoraproject.org/wiki/Licensing:Main#Bad_Licenses_3 Therefore the bitmaps would need to be removed/replaced or the package needs to go to a different repository such as RPMFusion: https://rpmfusion.org/FAQ#Nonfree_repository Also, the license information is shipped in the tarball, therefore it also needs to be shipped in the RPM using %license: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text The Source0 flag should be Source0: https://github.com/OWNER/PROJECT/archive/%{gittag}/%{name}-%{version}.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags This avoids tarballs that do not contain the package name like v1.47.tar.gz causing less confusion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
