https://bugzilla.redhat.com/show_bug.cgi?id=1981493 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- Informal only review. The library bundles several projects, which seems to have their own version and release tarballs at repo.hu [1]. At least for non-trivial parts, I think it should include entries like: Provides: bundled(liblihata) for all used directories in src_3rd. That would include at minimal libfungw, liblihata, genvector. Ideally those libraries should have own package, but I haven't found any trace requiring them. Because they have own versions and repos, they should be mentioned as bundled libraries [2]. Not sure how real support exist for those libraries in system, the build systems of this package is not something I full understand. What is main benefit of using %{nameAPI} instead of just %{name}? I think at least %{nameAPI} package should include: Provides: %{name} = %{version}-%{release} Does it expect installation of multiple versions on the same system? Is there reason for such approach? I know Debian packages use version of library always in the package name, but it is not common in Fedora. I think it is only used where multiple different versions have to be supported. -doc subpackage does not require main package, but does not have own copy of %license. Either require main package or include separate copy. License has to be installed always with any content from package. Even documentation. -static subpackage is not needed and should not be provided. Any code using this library should link to shared libraries, never static. At least anything packaged. Just rm lib*.a instead of separate package. Please remove index.html suffix from URL. It looks better without it and works. Source0 can be %{url}/releases/%{name}-%{version}.tar.gz, since the beginning is the same. genregex is Public Domain, I think it should be also in License: tag. 1. http://repo.hu/projects/ 2. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
