https://bugzilla.redhat.com/show_bug.cgi?id=1995127 --- Comment #7 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: a32b2fc876bc640b349a94e09c8b9fffefb27528 restool-2.3.0.tar.xz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. BAD license field matches the actual license. OK license is open source-compatible (BSD, GPLv2+). OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK package builds in mock (Rawhide/aarch64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - restool is dual licensed if I read it right, it should be "BSD or GPLv2+" - better to use %build_cflags/%build_ldflags as discussed earlier - rpmlint only complains about missing man pages for the ls-* tools - changelog refers to version 2.3, but the version tag is 2.3.0 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
