https://bugzilla.redhat.com/show_bug.cgi?id=1978188 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(notinsideofhereia | |mnotinside@xxxxxxxxx) CC| |pemensik@xxxxxxxxxx --- Comment #12 from Petr Menšík <pemensik@xxxxxxxxxx> --- I just stumbled across the review and noticed missing desktop-file-install or desktop-file-validate when desktop file is installed [1]. It is mandatory and mentioned already in comment #7. Not yet fixed. niohiani, you have granted review+, which is fine. But Martin needs to continue with "fedpkg request-repo qt6ct 1978188" command to request repository created. Such requests are always denied until you as a reviewer take the bug and change status to ASSIGNED. Without it he cannot continue even with your flag given. Please finish you review and take the bug. Except missing desktop file validation, you have made review well and can and should back your decision and assign your name to it. Do not be afraid and assign the bug to yourself. I would insist on desktop-file-validate first however. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
