Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: redet - Regular expression development and execution tool https://bugzilla.redhat.com/show_bug.cgi?id=397211 ------- Additional Comments From debarshi.ray@xxxxxxxxx 2007-11-24 14:49 EST ------- (In reply to comment #2) > I think that in the make install line, INSTALL="%{__install} -p" > is not useful, and that you should add > BINDIR=%{_bindir} BINDIR is not necessary since the Makefile sets it correctly using PREFIX. But it does not do that with MANDIR, and hence it had to be set explicitly. > Also it seems to me that in the sed that sets the /usr/share path > it would be better to use the rpm macro, like Ok. > Strangely, nothing is installed in %{_datadir}/Redet? Look below. > Also since you try hard to keep timestamps, I think it would be better > to keep them despite the sed. How do I do that with sed? I am not very familiar with it. > I think that xdg-open should be used instead of dillo as default > browser, and added as a dependency. Ok. I will fix this. > It would be nice to provide the manual. It is even > called from the program, from %{_datadir}/Redet/Manual/Manual.html > This would certainly mean using the redet-full-8.23.tar.bz2 > tarball. The manual is 4.9M in size and was historically provided by the redet-doc package. I have inherited it too, and will soon submit a review. Since the manual is so big in size, I do not want to put it in the main package and burden users with such big downloads. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review