https://bugzilla.redhat.com/show_bug.cgi?id=1993498 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking this review. Blocking issue: Do you know the license of those "data/nist/*" files? I *think* NIST should publish things into the public domain, but it would be good to check. Non-blocking minor issues: 1) Convert README to unix line encodings (possibly with dox2unix): rust-statrs-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-statrs-devel/README.md 2) Drop the "nightly" feature (it will never work in Fedora because we only have stable Rust). 3) Leave "# Initial patched metadata" generated comment in the spec file. 4) Open a PR / link the upstream PR for the nalgebra 0.27.1 → 0.29 bump. 5) Drop the useless "data" files from %doc: "%doc README.md CHANGELOG.md data/nist/numacc4.txt data/nist/numacc3.txt data/nist/numacc2.txt data/nist/numacc1.txt data/nist/michaelso.txt data/nist/mavro.txt data/nist/lottery.txt data/nist/lew.txt" Those do not look like documentation at all, but rather data. They should not be marked as %doc, leaving only "%doc README.md CHANGELOG.md". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
