https://bugzilla.redhat.com/show_bug.cgi?id=1990925 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |POST CC| |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is disabled with valid reasoning - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Two minor issues: 1) "resources/afl_crashes_20161215.txt" probably doesn't need to be marked as %doc, right? The file looks like american-fuzzy-lop fuzzer output or something like that? It's not even valid ASCII / UTF-8. 2) If the tests don't compile with quickcheck 1.0, then don't patch the version at all, just do "%bcond_with check" and add a comment that the quickcheck dev-dependency is outdated (maybe poke upstream about fixing that?) Please fix those two before importing the package. Other than that, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
