https://bugzilla.redhat.com/show_bug.cgi?id=1990944 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Doc Type|--- |If docs needed, set a value CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Two minor issues: 1) please leave the "# Initial patched metatada" comment in there Just for consistency with 99.9% of rust-sig packages. 2) "%doc examples README.md CHANGELOG.md assets/README.md" This will not do what you think. It's a bug in rust2rpm's new %doc and %license detection logic. "%doc README assets/README.md" will actually copy "README.md" to "%{_docdir}/README.md" and then prompty overwrite it with the second "README.md" from "assets/README.md". Additionally, the "examples" directory is already included by default in the same package (under /usr/share/cargo/registry/$crate/$version/ with all the other source files), so including this as %doc just makes them duplicate files within the same package for no reason. So please replace this %doc line with "%doc README.md CHANGELOG.md" before importing. Other than that, package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
