https://bugzilla.redhat.com/show_bug.cgi?id=1995127 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx CC| |dan@xxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #5 from Dan Horák <dan@xxxxxxxx> --- I would make few changes to the spec - drop the sed and set the prefix variable on a make commandline instead - use modern variable for the compiler/linker flags as shown bellow Full review will follow soon. @@ -28,14 +28,13 @@ %prep %autosetup -p1 -sed -i 's#/usr/local#/usr#g' Makefile %build # the maybe-uninitialized has been reported to upstream -%{make_build} EXTRA_CFLAGS="$RPM_OPT_FLAGS -Wno-error=maybe-uninitialized" LDFLAGS="$RPM_OPT_FLAGS" +%{make_build} EXTRA_CFLAGS="%{build_cflags} -Wno-error=maybe-uninitialized" LDFLAGS="%{build_ldflags}" %install -%{make_install} +%{make_install} prefix=%{_usr} %files %license COPYING -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
