https://bugzilla.redhat.com/show_bug.cgi?id=1992627 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |klember@xxxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review+ --- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> --- Looks good to me. I don't think this actually needs a formal review since there's a review exception for parallel installable versions. In any case, this looks good to me and follows packaging guidelines for parallel installable packages. I didn't do a full review here since it's essentially the same as existing mozjs78 and just a new, parallel installable version. Just some nits I noticed: > # Require libatomic for ppc > %ifarch ppc > %global system_libatomic 1 > %endif I think all of system_libatomic conditionals can go since we don't build for ppc any more. > export LINKFLAGS="%{?__global_ldflags}" > export PYTHON="%{__python3}" I believe (but not 100% sure) that the preferred versions to use these days are %{build_ldflags} and %{python3} (without leading underscores). > %ldconfig_scriptlets This can go as well: it expands to nothing on modern fedora. Great work with this! Thanks for putting in all the work of keeping mozjs up to date and packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
