https://bugzilla.redhat.com/show_bug.cgi?id=1977987 --- Comment #9 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- I had a quick look. Looks very good. I wasn't able to get fedora-review to run though, but I can't see anything wrong with the spec. The only additional note here is: - I think you may have to add the linker flags manually too since you're running the compilation commands yourself. %{optflags} doesn't include %{build_ldflags}. So your commands will be: gcc %{optflags} -std=c99 -o %{name}-sdl2 main_sdl.c -lSDL2 %{build_ldflags} gcc %{optflags} -std=c99 -o %{name}-test main_test.c %{build_ldflags} (You can set linker flags in multiple places on the compiler command line, but I remember reading somewhere that adding them at the end seems to work best---can't find the the post now :/) Cheers, -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
