https://bugzilla.redhat.com/show_bug.cgi?id=1991208 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Wolfgang Ulbrich from comment #2) > I picked up your review. A font review shouln't be so difficult or not? Well, I guess you are going to find out. :-) I had a couple of people turn that review down, due to feeling uncomfortable with font package reviews. (In reply to Yaakov Selkowitz from comment #3) > Since I started this just before it was taken, I'll add this as an informal > review. Thanks, Yaakov. You caught a couple of things that I missed. Here is my review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - In a multiple licensing scenario, the license breakdown must be described: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios In this case, what is licensed LGPLv2+? I only see the GPLv2+ in play. - Add "%license COPYING" to %files. - Note that Provides have been generated for two of the plugins: libbookmarks.so()(64bit) libwordcompletion.so()(64bit) Since they are in a private subdirectory of %{_libdir}, I don't think this is right. Something like this in this specfile should prevent it: %global __provides_exclude_from ^%{_libdir}/pluma/plugins - In %build, use "%make_build V=1" instead of the explicit make invocation. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make - Look at the first item under "EXTRA items" below. Is it possible to make a noarch subpackage to hold most or all of the files under /usr/share? - Note the unused-direct-shlib-dependency warnings in the rpmlint section below. That indicates that this project has run afoul of a long-standing libtool bug: it reorders -Wl,--as-needed *after* the libraries to be linked against, rendering it useless. I usually put this between %configure and %make_build for projects that use libtool: # Get rid of undesirable hardcoded rpaths; workaround libtool reordering # -Wl,--as-needed after all the libraries. sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \ -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \ -e 's|CC="\(.*g..\)"|CC="\1 -Wl,--as-needed"|' \ -i libtool If you don't have rpath problems, then the 3rd sed expression may be all you need. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. There is a COPYING file, but it is not included in the binary package. [!]: License field in the package spec file matches the actual license. License field includes "LGPLv2+", but I don't see any files with those license terms. [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). The shared object plugins should not generate Provides. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Upstream did not provide any tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3717120 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pluma-plugins-1.26.0-1.fc36.x86_64.rpm pluma-plugins-debuginfo-1.26.0-1.fc36.x86_64.rpm pluma-plugins-debugsource-1.26.0-1.fc36.x86_64.rpm pluma-plugins-1.26.0-1.fc36.src.rpm pluma-plugins.x86_64: E: explicit-lib-dependency libpeas-loader-python3 4 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: pluma-plugins-debuginfo-1.26.0-1.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libpeas-gtk-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libpangocairo-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libpango-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libharfbuzz.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libatk-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libcairo-gobject.so.2 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libcairo.so.2 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libgdk_pixbuf-2.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libgmodule-2.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libgio-2.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libbookmarks.so /lib64/libgirepository-1.0.so.1 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libgdk-3.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libpangocairo-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libpango-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libharfbuzz.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libatk-1.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libcairo-gobject.so.2 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libcairo.so.2 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libgdk_pixbuf-2.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libgmodule-2.0.so.0 pluma-plugins.x86_64: W: unused-direct-shlib-dependency /usr/lib64/pluma/plugins/libwordcompletion.so /lib64/libgirepository-1.0.so.1 pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_tab_get_view (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_message_bus_unregister_all (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_message_has_key (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_debug (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_view_get_type (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_document_set_metadata(/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_debug_message (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_message_bus_register (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_document_get_metadata(/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_type (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_tab_get_document (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_active_view(/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_ui_manager(/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_document_get_type (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_activatable_get_type (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_message_bus_connect (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_active_document (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_message_get (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_message_bus(/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libbookmarks.so pluma_window_get_views (/usr/lib64/pluma/plugins/libbookmarks.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libwordcompletion.so pluma_debug (/usr/lib64/pluma/plugins/libwordcompletion.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libwordcompletion.so pluma_view_get_type (/usr/lib64/pluma/plugins/libwordcompletion.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libwordcompletion.so pluma_debug_message (/usr/lib64/pluma/plugins/libwordcompletion.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libwordcompletion.so pluma_view_activatable_get_type (/usr/lib64/pluma/plugins/libwordcompletion.so) pluma-plugins.x86_64: W: undefined-non-weak-symbol /usr/lib64/pluma/plugins/libwordcompletion.so pluma_window_activatable_get_type (/usr/lib64/pluma/plugins/libwordcompletion.so) pluma-plugins.x86_64: W: package-with-huge-docs: 72% pluma-plugins.x86_64: W: files-duplicate /usr/share/help/zu/pluma-plugins/legal-plugins.xml /usr/share/help/af/pluma-plugins/legal-plugins.xml:/usr/share/help/am/pluma-plugins/legal-plugins.xml:/usr/share/help/an/pluma-plugins/legal-plugins.xml:/usr/share/help/ar/pluma-plugins/legal-plugins.xml:/usr/share/help/as/pluma-plugins/legal-plugins.xml:/usr/share/help/ast/pluma-plugins/legal-plugins.xml:/usr/share/help/az/pluma-plugins/legal-plugins.xml:/usr/share/help/be/pluma-plugins/legal-plugins.xml:/usr/share/help/bg/pluma-plugins/legal-plugins.xml:/usr/share/help/bn/pluma-plugins/legal-plugins.xml:/usr/share/help/bn_IN/pluma-plugins/legal-plugins.xml:/usr/share/help/br/pluma-plugins/legal-plugins.xml:/usr/share/help/bs/pluma-plugins/legal-plugins.xml:/usr/share/help/ca/pluma-plugins/legal-plugins.xml:/usr/share/help/ca@valencia/pluma-plugins/legal-plugins.xml:/usr/share/help/cmn/pluma-plugins/legal-plugins.xml:/usr/share/help/crh/pluma-plugins/legal-plugins.xml:/usr/share/help/cs/pluma-plugins/legal-plugins.xml:/usr/share/help/csb/pluma-plugins/legal-plugins.xml:/usr/share/help/cy/pluma-plugins/legal-plugins.xml:/usr/share/help/de/pluma-plugins/legal-plugins.xml:/usr/share/help/dz/pluma-plugins/legal-plugins.xml:/usr/share/help/el/pluma-plugins/legal-plugins.xml:/usr/share/help/en_AU/pluma-plugins/legal-plugins.xml:/usr/share/help/en_CA/pluma-plugins/legal-plugins.xml:/usr/share/help/en_GB/pluma-plugins/legal-plugins.xml:/usr/share/help/eo/pluma-plugins/legal-plugins.xml:/usr/share/help/es_AR/pluma-plugins/legal-plugins.xml:/usr/share/help/es_CL/pluma-plugins/legal-plugins.xml:/usr/share/help/es_CO/pluma-plugins/legal-plugins.xml:/usr/share/help/es_CR/pluma-plugins/legal-plugins.xml:/usr/share/help/es_DO/pluma-plugins/legal-plugins.xml:/usr/share/help/es_EC/pluma-plugins/legal-plugins.xml:/usr/share/help/es_ES/pluma-plugins/legal-plugins.xml:/usr/share/help/es_MX/pluma-plugins/legal-plugins.xml:/usr/share/help/es_NI/pluma-plugins/legal-plugins.xml:/usr/share/help/es_PA/pluma-plugins/legal-plugins.xml:/usr/share/help/es_PE/pluma-plugins/legal-plugins.xml:/usr/share/help/es_PR/pluma-plugins/legal-plugins.xm l:/usr/share/help/es_SV/pluma-plugins/legal-plugins.xml:/usr/share/help/es_UY/pluma-plugins/legal-plugins.xml:/usr/share/help/es_VE/pluma-plugins/legal-plugins.xml:/usr/share/help/et/pluma-plugins/legal-plugins.xml:/usr/share/help/eu/pluma-plugins/legal-plugins.xml:/usr/share/help/fa/pluma-plugins/legal-plugins.xml:/usr/share/help/frp/pluma-plugins/legal-plugins.xml:/usr/share/help/fur/pluma-plugins/legal-plugins.xml:/usr/share/help/fy/pluma-plugins/legal-plugins.xml:/usr/share/help/ga/pluma-plugins/legal-plugins.xml:/usr/share/help/gu/pluma-plugins/legal-plugins.xml:/usr/share/help/ha/pluma-plugins/legal-plugins.xml:/usr/share/help/he/pluma-plugins/legal-plugins.xml:/usr/share/help/hi/pluma-plugins/legal-plugins.xml:/usr/share/help/hr/pluma-plugins/legal-plugins.xml:/usr/share/help/hu/pluma-plugins/legal-plugins.xml:/usr/share/help/hy/pluma-plugins/legal-plugins.xml:/usr/share/help/ia/pluma-plugins/legal-plugins.xml:/usr/share/help/id/pluma-plugins/legal-plugins.xml:/usr/share/help/ig/pluma-plugins/legal-plugins.xml:/usr/share/help/is/pluma-plugins/legal-plugins.xml:/usr/share/help/jv/pluma-plugins/legal-plugins.xml:/usr/share/help/ka/pluma-plugins/legal-plugins.xml:/usr/share/help/kab/pluma-plugins/legal-plugins.xml:/usr/share/help/kk/pluma-plugins/legal-plugins.xml:/usr/share/help/km/pluma-plugins/legal-plugins.xml:/usr/share/help/kn/pluma-plugins/legal-plugins.xml:/usr/share/help/ko/pluma-plugins/legal-plugins.xml:/usr/share/help/ks/pluma-plugins/legal-plugins.xml:/usr/share/help/ku/pluma-plugins/legal-plugins.xml:/usr/share/help/ky/pluma-plugins/legal-plugins.xml:/usr/share/help/la/pluma-plugins/legal-plugins.xml:/usr/share/help/lb/pluma-plugins/legal-plugins.xml:/usr/share/help/lt/pluma-plugins/legal-plugins.xml:/usr/share/help/lv/pluma-plugins/legal-plugins.xml:/usr/share/help/mai/pluma-plugins/legal-plugins.xml:/usr/share/help/mg/pluma-plugins/legal-plugins.xml:/usr/share/help/mk/pluma-plugins/legal-plugins.xml:/usr/share/help/ml/pluma-plugins/legal-plugins.xml:/usr/share/help/mn/pluma-plugins/legal-plugi ns.xml:/usr/share/help/mr/pluma-plugins/legal-plugins.xml:/usr/share/help/nds/pluma-plugins/legal-plugins.xml:/usr/share/help/ne/pluma-plugins/legal-plugins.xml:/usr/share/help/nn/pluma-plugins/legal-plugins.xml:/usr/share/help/nso/pluma-plugins/legal-plugins.xml:/usr/share/help/oc/pluma-plugins/legal-plugins.xml:/usr/share/help/or/pluma-plugins/legal-plugins.xml:/usr/share/help/pa/pluma-plugins/legal-plugins.xml:/usr/share/help/ps/pluma-plugins/legal-plugins.xml:/usr/share/help/pt/pluma-plugins/legal-plugins.xml:/usr/share/help/pt_BR/pluma-plugins/legal-plugins.xml:/usr/share/help/ro/pluma-plugins/legal-plugins.xml:/usr/share/help/ru/pluma-plugins/legal-plugins.xml:/usr/share/help/rw/pluma-plugins/legal-plugins.xml:/usr/share/help/sc/pluma-plugins/legal-plugins.xml:/usr/share/help/si/pluma-plugins/legal-plugins.xml:/usr/share/help/sk/pluma-plugins/legal-plugins.xml:/usr/share/help/sl/pluma-plugins/legal-plugins.xml:/usr/share/help/sq/pluma-plugins/legal-plugins.xml:/usr/share/help/sr@latin/pluma-plugins/legal-plugins.xml:/usr/share/help/sv/pluma-plugins/legal-plugins.xml:/usr/share/help/sw/pluma-plugins/legal-plugins.xml:/usr/share/help/ta/pluma-plugins/legal-plugins.xml:/usr/share/help/te/pluma-plugins/legal-plugins.xml:/usr/share/help/th/pluma-plugins/legal-plugins.xml:/usr/share/help/tr/pluma-plugins/legal-plugins.xml:/usr/share/help/ug/pluma-plugins/legal-plugins.xml:/usr/share/help/uk/pluma-plugins/legal-plugins.xml:/usr/share/help/ur/pluma-plugins/legal-plugins.xml:/usr/share/help/ur_PK/pluma-plugins/legal-plugins.xml:/usr/share/help/uz/pluma-plugins/legal-plugins.xml:/usr/share/help/vi/pluma-plugins/legal-plugins.xml:/usr/share/help/wa/pluma-plugins/legal-plugins.xml:/usr/share/help/xh/pluma-plugins/legal-plugins.xml:/usr/share/help/yo/pluma-plugins/legal-plugins.xml:/usr/share/help/zh-Hans/pluma-plugins/legal-plugins.xml:/usr/share/help/zh_CN/pluma-plugins/legal-plugins.xml:/usr/share/help/zh_HK/pluma-plugins/legal-plugins.xml:/usr/share/help/zh_TW/pluma-plugins/legal-plugins.xml pluma-plugins.x86_64: W: files-duplicate /usr/share/help/ie/pluma-plugins/legal-plugins.xml /usr/share/help/da/pluma-plugins/legal-plugins.xml pluma-plugins.x86_64: W: files-duplicate /usr/share/pluma/plugins/sourcecodebrowser/icons/source-code-browser.png /usr/share/pluma/plugins/sourcecodebrowser/icons/source-class.png pluma-plugins.x86_64: W: files-duplicate /usr/share/pluma/plugins/sourcecodebrowser/icons/source-typedef.png /usr/share/pluma/plugins/sourcecodebrowser/icons/source-define.png:/usr/share/pluma/plugins/sourcecodebrowser/icons/source-enumerator.png:/usr/share/pluma/plugins/sourcecodebrowser/icons/source-field.png:/usr/share/pluma/plugins/sourcecodebrowser/icons/source-macro.png pluma-plugins.x86_64: W: files-duplicate /usr/share/pluma/plugins/sourcecodebrowser/icons/source-method.png /usr/share/pluma/plugins/sourcecodebrowser/icons/source-function.png:/usr/share/pluma/plugins/sourcecodebrowser/icons/source-member.png pluma-plugins.x86_64: E: explicit-lib-dependency libpeas-loader-python3 ================ 1 packages and 0 specfiles checked; 1 errors, 52 warnings, 1 badness; has taken 0.9 s ================= Unversioned so-files -------------------- pluma-plugins: /usr/lib64/pluma/plugins/libbookmarks.so pluma-plugins: /usr/lib64/pluma/plugins/libwordcompletion.so Requires -------- pluma-plugins (rpmlib, GLIBC filtered): /usr/bin/python3 libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libgirepository-1.0.so.1()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtksourceview-4.so.0()(64bit) libharfbuzz.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpeas-1.0.so.0()(64bit) libpeas-gtk-1.0.so.0()(64bit) libpeas-loader-python3 pluma rtld(GNU_HASH) pluma-plugins-debuginfo (rpmlib, GLIBC filtered): pluma-plugins-debugsource (rpmlib, GLIBC filtered): Provides -------- pluma-plugins: libbookmarks.so()(64bit) libwordcompletion.so()(64bit) metainfo() metainfo(pluma-bookmarks.metainfo.xml) metainfo(pluma-codecomment.metainfo.xml) metainfo(pluma-synctex.metainfo.xml) metainfo(pluma-terminal.metainfo.xml) pluma-plugins pluma-plugins(x86-64) pluma-plugins-debuginfo: debuginfo(build-id) libbookmarks.so-1.26.0-1.fc36.x86_64.debug()(64bit) libwordcompletion.so-1.26.0-1.fc36.x86_64.debug()(64bit) pluma-plugins-debuginfo pluma-plugins-debuginfo(x86-64) pluma-plugins-debugsource: pluma-plugins-debugsource pluma-plugins-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1991208 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, C/C++, Shell-api, Generic Disabled plugins: Ocaml, Java, PHP, fonts, SugarActivity, R, Perl, Ruby, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
