https://bugzilla.redhat.com/show_bug.cgi?id=1995266 --- Comment #1 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ --> to be fixed with a new release - Changelog is missing - SRPM could be named `mirrors-countme` instead -- its main component isn't the Python package but the executable scripts. - Has a %check section which calls `python setup.py test` instead of pytest which runs no tests at all. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. --> Changelog is missing [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. --> Name the SRPM `mirrors-countme` instead? -- from the guidelines: "Packages that primarily provide applications, services or any kind of executables SHOULD be named according to the general Fedora naming guidelines (e.g. ansible)." [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. --> need to run pytest instead (and require pytest, pytest-cov) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/nils/devel/reviews/fedora/1995266-python-mirrors-countme/srpm- unpacked/python-mirrors-countme.spec See: (this test has no URL) --> I don't have a clue what it's complaining about, do you? [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-mirrors-countme-0.0.4-1.el8.noarch.rpm python-mirrors-countme-0.0.4-1.el8.src.rpm python3-mirrors-countme.noarch: W: summary-not-capitalized C access_log parsing & host counting for DNF mirrors --> we need to fix that python3-mirrors-countme.noarch: W: spelling-error %description -l en_US httpd -> HTTP --> bogus python3-mirrors-countme.noarch: E: no-changelogname-tag --> see above python3-mirrors-countme.noarch: W: no-manual-page-for-binary countme-csv2sqlite.sh python3-mirrors-countme.noarch: W: no-manual-page-for-binary countme-sqlite2csv.sh python3-mirrors-countme.noarch: W: no-manual-page-for-binary countme-totals.py python3-mirrors-countme.noarch: W: no-manual-page-for-binary countme-update-rawdb.sh python3-mirrors-countme.noarch: W: no-manual-page-for-binary countme-update-totals.sh python3-mirrors-countme.noarch: W: no-manual-page-for-binary parse-access-log.py --> we'll ignore this python-mirrors-countme.src: W: summary-not-capitalized C access_log parsing & host counting for DNF mirrors python-mirrors-countme.src: W: spelling-error %description -l en_US httpd -> HTTP python-mirrors-countme.src: E: no-changelogname-tag --> same as above 2 packages and 0 specfiles checked; 2 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name python3-mirrors-countme 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://pagure.io/mirrors-countme/archive/0.0.4/mirrors-countme-0.0.4.tar.gz : CHECKSUM(SHA256) this package : 4d0584875f0e80d4a6cf81500af99222a1a080fa07232b65ef01708845df7daa CHECKSUM(SHA256) upstream package : 317de77e88d60cb9e5fa2c7fcfaa2b888691308280dc08e68b9d1a8eb6e08690 diff -r also reports differences Requires -------- python3-mirrors-countme (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python3.6 python(abi) Provides -------- python3-mirrors-countme: python3-mirrors-countme python3.6dist(mirrors-countme) python3dist(mirrors-countme) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1995266 -m /etc/mock/epel-8-x86_64.cfg Buildroot used: epel-8-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Java, Ocaml, R, C/C++, Perl, PHP, Haskell, SugarActivity, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
