https://bugzilla.redhat.com/show_bug.cgi?id=1993592 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(robinlee.sysu@gma | |il.com) Assignee|nobody@xxxxxxxxxxxxxxxxx |code@xxxxxxxxxxxxxxxxxx CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ It only compiles a dummy main.cpp (presumably due to qmake limitations) and does not install it, but you still need: BuildRequires: gcc-c++ - While I guess qt5-qtbase-devel brings it in indirectly, I think you should still have BuildRequires: make since it is used directly. See https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/reviewer/1993592-dtkcommon/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ From diff.txt: Only in /home/reviewer/1993592-dtkcommon/srpm-unpacked/dtkcommon-5.5.17.tar.gz-extract/dtkcommon-5.5.17: .packit.yaml Only in /home/reviewer/1993592-dtkcommon/srpm-unpacked/dtkcommon-5.5.17.tar.gz-extract/dtkcommon-5.5.17: rpm Please make sure the SRPM contains the exact same tarball that is available at the Source URL. It doesn’t look like the differences are very significant. - Change %define debug_package %{nil} to %global debug_package %{nil} (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_global_preferred_over_define) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU Lesser General Public License v3.0 or later", "GNU General Public License v3.0 or later". 24 files have unknown license. Detailed output of licensecheck in /home/reviewer/1993592-dtkcommon/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/cmake/Dtk(dtkcore- devel) It is reasonable to co-own this directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream does not provide any tests. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dtkcommon-5.5.17-1.fc36.aarch64.rpm dtkcommon-devel-5.5.17-1.fc36.aarch64.rpm dtkcommon-5.5.17-1.fc36.src.rpm dtkcommon.aarch64: E: no-binary dtkcommon-devel.aarch64: W: only-non-binary-in-usr-lib dtkcommon-devel.aarch64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/linuxdeepin/dtkcommon/archive/5.5.17/dtkcommon-5.5.17.tar.gz : CHECKSUM(SHA256) this package : 2f0c12b8ef2acf2856dd06a2a2774510d3b3a9ce25d7931b0aa1cfd38740345a CHECKSUM(SHA256) upstream package : 2249150dcd89fc6a66c8a9bdbd76e27ae83082be7cffe6fad0d4e7600c66ed31 diff -r also reports differences Requires -------- dtkcommon (rpmlib, GLIBC filtered): glib2(aarch-64) dtkcommon-devel (rpmlib, GLIBC filtered): cmake-filesystem(aarch-64) dtkcommon(aarch-64) qt5-qtbase-devel(aarch-64) Provides -------- dtkcommon: dtkcommon dtkcommon(aarch-64) dtkcommon-devel: cmake(Dtk) cmake(dtk) dtkcommon-devel dtkcommon-devel(aarch-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1993592 Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, R, fonts, Ocaml, Python, SugarActivity, Perl, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
