https://bugzilla.redhat.com/show_bug.cgi?id=1982210 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- I'm sorry for the delay. I did not have much free time recently. This is a rebase, reviewing from the beginning. URL and Source0 addresses are usable. Ok. Source0 archive (SHA-512) 5a3321db635a81f6f67d5789cf374d846f21003a9bd3fd748bb58481d8a5fde450a1c4b5ad4d3edee49804cee6dd8da6ad7b4422eaef96bb333b8b3059cb3e41) is original. Ok. TODO: Move "%global __provides_exclude_from" just above a description section. This where we usually place the filtering macros. Summary is Ok. Description is Ok. FIX: share/shutter/resources/icons/drawing_tool/cursor files are GPLv2+ according to README. FIX: List the licenses of all the packaged files into the License section ("License: GPLv3+ and GPLv2+ and GPLv2 and CC-BY-SA and MIT and CC0 and Public Domain"). $ rpmlint shutter.spec ../SRPMS/shutter-0.98-3.fc36.src.rpm ../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm ============================================================= rpmlint session starts ============================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 shutter.noarch: W: dangling-symlink /usr/share/shutter/resources/icons/drawing_tool/objects/Tango /usr/share/icons/Tango/scalable shutter.noarch: W: cross-directory-hard-link /usr/share/pixmaps/shutter.png /usr/share/icons/hicolor/48x48/apps/shutter.png shutter.noarch: W: cross-directory-hard-link /usr/share/shutter/resources/icons/drawing_tool/draw-image.svg /usr/share/shutter/resources/icons/Image.svg shutter.noarch: W: cross-directory-hard-link /usr/share/shutter/resources/icons/drawing_tool/objects/Cursors/Normal.cur /usr/share/shutter/resources/icons/Normal.cur ============================== 2 packages and 1 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.8 s ============================= TODO: I recommend creating symbolic links (ln -s) instead of hard links in the %install section. If a user had the files on different file systems, they would become duplicated. File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm | sort -f | uniq -c 1 /usr/bin/bash 1 /usr/bin/perl 1 hicolor-icon-theme 1 ImageMagick 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(:VERSION) >= 5.10.1 1 perl(base) 1 perl(Carp::Always) 1 perl(constant) 1 perl(Data::Dumper) 1 perl(diagnostics) 1 perl(Digest::MD5) 1 perl(Encode) 1 perl(Encode::Locale) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Copy) 1 perl(File::Copy::Recursive) 1 perl(File::Glob) 1 perl(File::Spec) 1 perl(File::stat) 1 perl(File::Temp) 1 perl(File::Which) 1 perl(FindBin) 1 perl(Getopt::Long) 1 perl(Glib) 1 perl(Glib::Object::Introspection) 1 perl(Glib::Object::Subclass) 1 perl(Goo::Canvas) 1 perl(GooCanvas2) 2 perl(GooCanvas2::CairoTypes) 1 perl(Gtk3) 2 perl(Gtk3::ImageView) >= 9 1 perl(Gtk3::ImageView::Tool::Selector) 1 perl(HTTP::Request::Common) 1 perl(HTTP::Status) 1 perl(Image::ExifTool) 1 perl(Image::Magick) 1 perl(IO::File) 1 perl(JSON::MaybeXS) 1 perl(lib) 1 perl(List::Util) 1 perl(Locale::gettext) 1 perl(LWP::UserAgent) 1 perl(MIME::Base64) 1 perl(Net::DBus) 1 perl(Net::FTP) 1 perl(Number::Bytes::Human) 1 perl(Pango) 1 perl(Path::Class) 1 perl(Pod::Usage) 1 perl(POSIX) 1 perl(Proc::Killfam) 1 perl(Proc::Simple) 1 perl(Readonly) 1 perl(Shutter::App::AboutDialog) 1 perl(Shutter::App::Autostart) 1 perl(Shutter::App::Common) 1 perl(Shutter::App::Directories) 1 perl(Shutter::App::GlobalSettings) 1 perl(Shutter::App::HelperFunctions) 1 perl(Shutter::App::Menu) 1 perl(Shutter::App::Notification) 1 perl(Shutter::App::Optional::Exif) 1 perl(Shutter::App::Options) 1 perl(Shutter::App::ShutterNotification) 1 perl(Shutter::App::SimpleDialogs) 1 perl(Shutter::App::Toolbar) 1 perl(Shutter::Geometry::Region) 1 perl(Shutter::Pixbuf::Border) 1 perl(Shutter::Pixbuf::Load) 1 perl(Shutter::Pixbuf::Save) 1 perl(Shutter::Screenshot::Error) 1 perl(Shutter::Screenshot::History) 1 perl(Shutter::Screenshot::ImageViewSelector) 1 perl(Shutter::Screenshot::Main) 1 perl(Shutter::Screenshot::SelectorAdvanced) 1 perl(Shutter::Screenshot::SelectorAuto) 1 perl(Shutter::Screenshot::Web) 1 perl(Shutter::Screenshot::Window) 1 perl(Shutter::Screenshot::WindowName) 1 perl(Shutter::Screenshot::WindowXid) 1 perl(Shutter::Screenshot::Workspace) 1 perl(Shutter::Upload::FTP) 1 perl(Shutter::Upload::Shared) 1 perl(Sort::Naturally) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(URI) 1 perl(URI::Escape) 1 perl(URI::Split) 1 perl(utf8) 1 perl(warnings) 1 perl(WebService::Dropbox) 1 perl(WWW::Mechanize) 1 perl(X11::Protocol::Ext::XFIXES) 1 perl(XML::Simple) 1 perl-Pango 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 tango-icon-theme TODO: Do not explicitly run-require perl(GooCanvas2::CairoTypes) and perl(Gtk3::ImageView). They are found automatically. FIX: Do not run-require perl-Pango. It is found as perl(Pango) automatically. $ rpm -q --provides -p ../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm | sort -f | uniq -c 1 application() 1 application(shutter.desktop) 1 metainfo() 1 metainfo(shutter.appdata.xml) 1 mimehandler(image/bmp) 1 mimehandler(image/gif) 1 mimehandler(image/jpeg) 1 mimehandler(image/png) 1 mimehandler(image/svg+xml) 1 mimehandler(image/tiff) 1 mimehandler(image/x-bmp) 1 mimehandler(image/x-ico) 1 mimehandler(image/x-pcx) 1 mimehandler(image/x-png) 1 mimehandler(image/x-tga) 1 mimehandler(image/xpm) 1 perl(Gtk3::IconSize) 1 perl(Shutter::App::AboutDialog) 1 perl(Shutter::App::Autostart) 1 perl(Shutter::App::Common) 1 perl(Shutter::App::Directories) 1 perl(Shutter::App::GlobalSettings) 1 perl(Shutter::App::HelperFunctions) 1 perl(Shutter::App::Menu) 1 perl(Shutter::App::Notification) 1 perl(Shutter::App::Optional::Exif) 1 perl(Shutter::App::Options) 1 perl(Shutter::App::ShutterNotification) 1 perl(Shutter::App::SimpleDialogs) 1 perl(Shutter::App::Toolbar) 1 perl(Shutter::Draw::DrawingTool) 1 perl(Shutter::Geometry::Region) 1 perl(Shutter::Pixbuf::Border) 1 perl(Shutter::Pixbuf::Load) 1 perl(Shutter::Pixbuf::Save) 1 perl(Shutter::Screenshot::Error) 1 perl(Shutter::Screenshot::History) 1 perl(Shutter::Screenshot::ImageViewSelector) 1 perl(Shutter::Screenshot::Main) 1 perl(Shutter::Screenshot::SelectorAdvanced) 1 perl(Shutter::Screenshot::SelectorAuto) 1 perl(Shutter::Screenshot::Web) 1 perl(Shutter::Screenshot::Window) 1 perl(Shutter::Screenshot::WindowName) 1 perl(Shutter::Screenshot::WindowXid) 1 perl(Shutter::Screenshot::Workspace) 1 perl(Shutter::Upload::FTP) 1 perl(Shutter::Upload::Shared) 1 shutter = 0.98-3.fc36 FIX: Do not provide perl(Gtk3::IconSize). It's a private redefinition. $ resolvedeps rawhide ../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 36 (https://koji.fedoraproject.org/koji/taskinfo?taskID=74083215). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing TODO items, and provide an updated spec file. Resolution: NOT approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
