https://bugzilla.redhat.com/show_bug.cgi?id=1988151 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thanks for the review! > - Note the description-line-too-long warning from rpmlint. There is a macro on > the indicated line that expands to a fairly long string. Thanks! I’ll fix this. > - Regarding support for ppc64le and s390x, it looks like the only assembly is > in defs.h, used to define the spin_loop_pause() function, right? Correct, this is the only bit that has to be written to enable additional architectures. I’d love to be able to fill in the missing architectures. > If that is > the case, then it would be correct (although unfriendly to the CPU) to define > an empty spin_loop_pause() function, or to expand to whatever the no-op > instruction is for each platform. For PowerPC, something like this (largely > stolen from the Linux kernel's arch/powerpc/include/asm/vdso/processor.h): > > […] > > I know you aren't upstream, just saying that if you want to see the > ExclusiveArch go away, it may not be too difficult to make that happen. Your suggestions are probably correct, but since this package is MIT-licensed, I can’t use anything copied from the GPL-licensed Linux kernel, and I don’t know either missing architecture well enough to craft something I am confident in from first principles. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
