https://bugzilla.redhat.com/show_bug.cgi?id=1988517 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(loganjerry@gmail. | |com) --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > - Sources used to build the package match the upstream source, as provided > in the spec URL. > Note: Upstream MD5sum check error, diff is in > /home/jamesjer/1988517-dr_libs/diff.txt > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > Briefly, the top-level Makefile is different in the upstream tarball from the > tarball you provided. Thanks! I have corrected this. > - While Fedora's LDFLAGS are used to build, Fedora's CFLAGS are not. Since the > binaries are not packaged, maybe that doesn't matter. Good catch; thanks! The CFLAGS were supposed to be used. I have corrected the Makefile. > - Should the packages be noarch? No, although a reasonable person would think so, since the header files themselves are arch-independent. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_do_not_use_noarch, which mandates and justifies “archedness” for all header-only library packages. ----- I also updated to the latest upstream version(s). You should also find that the tests now compile without compiler warnings. I set -Wno-long-long in the Makefile, with a comment to justify doing so, and I sent a PR upstream and applied a patch to deal with a signed/unsigned comparison warning stemming from an assumption about the maximum number of frames in the FLAC files under test—a rather picky detail in practice, since only the test code is affected. ----- Updated spec URL: https://music.fedorapeople.org/20210816/dr_libs.spec Updated spec URL: https://music.fedorapeople.org/20210816/dr_libs-0-0.1.20210816gitb36bc43.fc34.src.rpm Koji scratch builds: F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=73964973 F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=73964981 F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=73964986 F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=73964997 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
