https://bugzilla.redhat.com/show_bug.cgi?id=1982631 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |oturpe@xxxxxx CC| |oturpe@xxxxxx Flags| |fedora-review? | |needinfo?(ce@xxxxxxx) --- Comment #1 from Otto Urpelainen <oturpe@xxxxxx> --- Reviewed. These are now fast, as I got a hold of reviewing php libraries. Findings: 1. > Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php Replace with format that cannot be confused with a specfile tag. 2. > %if 0%{?with_tests} > : Run tests > : No tests implemented > %endif There are tests, in the spec/ directory. Need to use makesrc.sh to include them. 3. >From fedora-review: > Note: Directories without known owners: /usr/share/php/Http For package php-leagure-uri-interface, we agreed to solve similar problem by sharing the vendor directory ownership between all packages from that vendor. I suppose the same solution can be applied here, too? 4. > URL: https://github.com/%{gh_vendor}/%{gh_project} composer.json lists this as http://httplug.io. Just noting this, I do not really have clear opinion if it is better to link to the library source repository or to umbrella project's homepage. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
