https://bugzilla.redhat.com/show_bug.cgi?id=1982633 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ce@xxxxxxx) --- Comment #1 from Otto Urpelainen <oturpe@xxxxxx> --- Reviewed, findings are: 1. > URL: https://github.com/%{gh_vendor}/%{gh_project} It is mostly a matter of taste if project source repository or homepage is used here, but note that composer.json lists homepage as https://uri.thephpleague.com/ You can change this or not, whatever you feel is the best. 2. > Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php Say "The library autoloader is:" to avoid possibility of confusing this with specfile macros. 3. > %if 0%{?with_tests} > : Run tests > : No tests implemented > %endif There are tests, so need to use makesrc.sh here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
