https://bugzilla.redhat.com/show_bug.cgi?id=1981138 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > It seems like the Requires should be specific to the consuming package, not > universally required for all of these cmake macros. Are they really > necessary for any use of this package? Should they be Recommends rather than > Requires? I was torn on this, because the macros in this package generate the documentation templates that have these dependencies. I don’t like the idea that, when packaging something that depends on this package, you should have to dig through the contents of this package to find out what dependencies you need to add for documentation generation to work. On the other hand, it is true that dependent packages are likely to use Doxygen or Sphinx but not both, and each is a pretty heavy dependency to add unconditionally. Making the dependencies weak seems like it could be reasonable. It won’t make much difference in practice, though, since the package will mainly be used as a build dependency and weak dependencies will be installed in mock/koji. I think I’m going to add -sphinx and -doxygen subpackages that are metapackages bringing in the necessary additional dependencies. That way the base install of the macros will not bring in a documentation system; this package can be responsible for tracking the necessary themes and such as they potentially change over time; and the complexity of this package is only slightly increased. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
