https://bugzilla.redhat.com/show_bug.cgi?id=1992914 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Taking. Would you instead review my review request? https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1992931 Some comments: * release number and last %changelog entry mismatch. (%changelog in spec file in .src.rpm ends with -10) (New %changelog date format (including time and time difference) does not seem to be supported on rpmlint, also this would cause error / warning when building this when doing 'fedpkg build' after importing this to fedora dist-git. I suggest to use old date format.) * Check if files in %doc are really needed. Especially, spec/ Rakefile Gemfile should not be needed. I also suggest to remove %{gem_instdir}/%{gem_name}.gemspec . * Note (not a blocker): rspec -I rspec spec now causes warnings. Please consider to check https://github.com/mitchellh/middleware/pull/15/commits/f559ee1a5fbc625b3a629f64d03f4ce249ea2fa0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
