https://bugzilla.redhat.com/show_bug.cgi?id=1988952 --- Comment #3 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Artur Frenszek-Iwicki from comment #2) > > I think lowercase package name should be used. > The "normal" SFML package has an upper-case name, so that's why I went with > that. SDL and SDL2 do this as well. > https://src.fedoraproject.org/rpms/SFML Okay, I take it back. Guidelines mention recommended case is lower [1], but if upstream wants it uppercase, it can be. Upstream seems to reference to it always uppercase [2]. DNF does not care anyway and would accept dnf install csfml. I were surprised dnf install sfml-devel passed when the package is SFML-devel. If SFML is also uppercase, it should be similar way. rpm requires correct case, dnf does not. > > > I would recommend including first number of library so version in non-devel package instead of %{_libdir}/*.so.*. > I'll take a look at how other packages handle this. It helps watching for binary incompatible upgrades if so version in included in name. For libcsfml-audio.so.2.5 it might be %{_libdir}/libcsfml-*.so.2* If it upgrades to %{_libdir}/libcsfml-*.so.3* later, it would require all depending packages to be rebuilt with new library. Explicit change in spec helps to remember when such action might be needed. When upgrade is not just internal improvements, but also incompatible public API changes. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity 2. https://www.sfml-dev.org/download/csfml/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
