https://bugzilla.redhat.com/show_bug.cgi?id=1991096 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > Patch0: 0001-Remove-dep-on-mock-as-is-part-of-python-3.6.patch Please add https://github.com/kmike/port-for/pull/39 to comment. All patches need to be justified, ideally with upstream link. > BuildRequires: python3dist(setuptools) > BuildRequires: python3-pytest > BuildRequires: python3-pytest-cov > BuildRequires: python3dist(cov-core) Mixing the two types of BuildRequires is weird. Also, please don't use coverage during build: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters > %{?python_provide:%python_provide python3-%{pypi_name}} This is deprecated and no longer needed. > rm -rf %{pypi_name}.egg-info This is not needed. > %{python3_sitelib}/%{name_with_underscore} > %{python3_sitelib}/%{name_with_underscore}-%{version}-py%{python3_version}.egg-info Consider adding trailing slashes to ensure those are directories. Consider using the new pyproject macros. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
