https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Jarek Prokop <jprokop@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jarek Prokop <jprokop@xxxxxxxxxx> --- if both packages provide the `ronn` binary, it is better to use `BuildRequires: %{_bindir}/ronn`: This minimal patch should work ~~~ -%if 0%{?fedora} < 34 -BuildRequires: rubygem(ronn) -%else -BuildRequires: rubygem(ronn-ng) -%endif +BuildRequires: %{_bindir}/ronn ~~~ JFTR upstream provides man pages which could be used as additional source instead like this: `Source1: https://github.com/defunkt/%{gem_name}/blob/v%{version}/build/%{gem_name}.1` I recommend querying upstream if they could include it in the built gem on RubyGems. * The Summary and Descriptions seem to differ from the upstream, let's keep it consistent with upstream. * Vendored library `vendor/json.rb` - While upstream has a use-case for this we do not as it is for homebrew users (AFAICT from the repo), the file should be deleted for distribution in Fedora Linux. - There should probably be added a license header on that file and an addition to the package's `License:` field if the file is kept in the resulting RPM, since it looks like it was copied from merging 2 files from upstream Ruby: https://github.com/flori/json/tree/master/lib/json/pure And a small nit: * The `BuildRequires: rubygem(rspec) > 3` restricting condition is probably not needed as Fedora in general ships rubygem-rspec > 3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
