https://bugzilla.redhat.com/show_bug.cgi?id=1991064 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > %install > ... > desktop-file-validate %{buildroot}%{_datadir}/applications/anagramarama.desktop > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/anagramarama.metainfo.xml I'd argue these two should go in %check. > %files > ... > %{_datadir}/man/man6/anagramarama.6.gz Do not assume man pages will be gzipped. Use a wildcard that can match any compression method (including no compression). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages > %files > %{_datadir}/anagramarama This directory is almost 10MiB in size. I'd consider separating it into an "anagramarama-data" sub-package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
