https://bugzilla.redhat.com/show_bug.cgi?id=1986602 --- Comment #15 from Sandro Mani <manisandro@xxxxxxxxx> --- Buuid succeeded now! Issues: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.10/site-packages/azure/cli, /usr/lib/python3.10/site- => Your main package and subpackages should have %dir %{python3_sitelib}/azure/ in the respective %files section to co-own that directory Your subpackages should require the main package, or also co-own %dir %{python3_sitelib}/azure/cli/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/bash-completion.d, /usr/lib/python3.10/site-packages/azure/cli, /usr/lib/python3.10/site- packages/azure [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-azure-cli-core , python3-azure-cli-telemetry , python3-azure- cli-testsdk [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/Azure/azure-cli/archive/azure-cli-2.26.1/azure-cli-azure-cli-2.26.1.tar.gz : CHECKSUM(SHA256) this package : b69c02fe2ba75cbf403c642441310004271ab7c3e7496b17007870fabb5411ac CHECKSUM(SHA256) upstream package : b69c02fe2ba75cbf403c642441310004271ab7c3e7496b17007870fabb5411ac Requires -------- azure-cli (rpmlib, GLIBC filtered): ((python3.10dist(azure-cosmos) >= 3 with python3.10dist(azure-cosmos) < 4) with python3.10dist(azure-cosmos) >= 3.0.2) (python3.10dist(azure-appconfiguration) >= 1.1.1 with python3.10dist(azure-appconfiguration) < 1.2) (python3.10dist(azure-batch) >= 10 with python3.10dist(azure-batch) < 10.1) (python3.10dist(azure-datalake-store) >= 0.0.49 with python3.10dist(azure-datalake-store) < 0.1) (python3.10dist(azure-functions-devops-build) >= 0.0.22 with python3.10dist(azure-functions-devops-build) < 0.1) (python3.10dist(azure-graphrbac) >= 0.60 with python3.10dist(azure-graphrbac) < 0.61) (python3.10dist(azure-keyvault) >= 1.1 with python3.10dist(azure-keyvault) < 1.2) (python3.10dist(azure-loganalytics) >= 0.1 with python3.10dist(azure-loganalytics) < 0.2) (python3.10dist(azure-mgmt-apimanagement) >= 0.2 with python3.10dist(azure-mgmt-apimanagement) < 0.3) (python3.10dist(azure-mgmt-appconfiguration) >= 2 with python3.10dist(azure-mgmt-appconfiguration) < 2.1) (python3.10dist(azure-mgmt-applicationinsights) >= 1 with python3.10dist(azure-mgmt-applicationinsights) < 1.1) (python3.10dist(azure-mgmt-authorization) >= 0.61 with python3.10dist(azure-mgmt-authorization) < 0.62) (python3.10dist(azure-mgmt-batch) >= 15 with python3.10dist(azure-mgmt-batch) < 15.1) (python3.10dist(azure-mgmt-batchai) >= 2 with python3.10dist(azure-mgmt-batchai) < 3) (python3.10dist(azure-mgmt-botservice) >= 0.3 with python3.10dist(azure-mgmt-botservice) < 0.4) (python3.10dist(azure-mgmt-cognitiveservices) >= 12 with python3.10dist(azure-mgmt-cognitiveservices) < 12.1) (python3.10dist(azure-mgmt-compute) >= 21 with python3.10dist(azure-mgmt-compute) < 21.1) (python3.10dist(azure-mgmt-consumption) >= 2 with python3.10dist(azure-mgmt-consumption) < 3) (python3.10dist(azure-mgmt-containerinstance) >= 1.4 with python3.10dist(azure-mgmt-containerinstance) < 2) (python3.10dist(azure-mgmt-containerservice) >= 16 with python3.10dist(azure-mgmt-containerservice) < 16.1) (python3.10dist(azure-mgmt-cosmosdb) >= 6.4 with python3.10dist(azure-mgmt-cosmosdb) < 6.5) (python3.10dist(azure-mgmt-databoxedge) >= 0.2 with python3.10dist(azure-mgmt-databoxedge) < 0.3) (python3.10dist(azure-mgmt-datalake-analytics) >= 0.2.1 with python3.10dist(azure-mgmt-datalake-analytics) < 0.3) (python3.10dist(azure-mgmt-datalake-store) >= 0.5 with python3.10dist(azure-mgmt-datalake-store) < 0.6) (python3.10dist(azure-mgmt-datamigration) >= 4.1 with python3.10dist(azure-mgmt-datamigration) < 4.2) (python3.10dist(azure-mgmt-deploymentmanager) >= 0.2 with python3.10dist(azure-mgmt-deploymentmanager) < 0.3) (python3.10dist(azure-mgmt-devtestlabs) >= 4 with python3.10dist(azure-mgmt-devtestlabs) < 5) (python3.10dist(azure-mgmt-dns) >= 8 with python3.10dist(azure-mgmt-dns) < 8.1) (python3.10dist(azure-mgmt-eventhub) >= 4.1 with python3.10dist(azure-mgmt-eventhub) < 4.2) (python3.10dist(azure-mgmt-extendedlocation) >= 1~b2 with python3.10dist(azure-mgmt-extendedlocation) < 1.1) (python3.10dist(azure-mgmt-hdinsight) >= 8 with python3.10dist(azure-mgmt-hdinsight) < 8.1) (python3.10dist(azure-mgmt-imagebuilder) >= 0.4 with python3.10dist(azure-mgmt-imagebuilder) < 0.5) (python3.10dist(azure-mgmt-iotcentral) >= 4.1 with python3.10dist(azure-mgmt-iotcentral) < 4.2) (python3.10dist(azure-mgmt-iothubprovisioningservices) >= 0.2 with python3.10dist(azure-mgmt-iothubprovisioningservices) < 0.3) (python3.10dist(azure-mgmt-kusto) >= 0.3 with python3.10dist(azure-mgmt-kusto) < 0.4) (python3.10dist(azure-mgmt-loganalytics) >= 8 with python3.10dist(azure-mgmt-loganalytics) < 8.1) (python3.10dist(azure-mgmt-managedservices) >= 1 with python3.10dist(azure-mgmt-managedservices) < 2) (python3.10dist(azure-mgmt-managementgroups) >= 0.1 with python3.10dist(azure-mgmt-managementgroups) < 1) (python3.10dist(azure-mgmt-maps) >= 0.1 with python3.10dist(azure-mgmt-maps) < 0.2) (python3.10dist(azure-mgmt-media) >= 3 with python3.10dist(azure-mgmt-media) < 4) (python3.10dist(azure-mgmt-monitor) >= 2 with python3.10dist(azure-mgmt-monitor) < 2.1) (python3.10dist(azure-mgmt-msi) >= 0.2 with python3.10dist(azure-mgmt-msi) < 1) (python3.10dist(azure-mgmt-netapp) >= 4 with python3.10dist(azure-mgmt-netapp) < 4.1) (python3.10dist(azure-mgmt-network) >= 19 with python3.10dist(azure-mgmt-network) < 19.1) (python3.10dist(azure-mgmt-policyinsights) >= 0.5 with python3.10dist(azure-mgmt-policyinsights) < 0.6) (python3.10dist(azure-mgmt-privatedns) >= 1 with python3.10dist(azure-mgmt-privatedns) < 1.1) (python3.10dist(azure-mgmt-rdbms) >= 8.1~b4 with python3.10dist(azure-mgmt-rdbms) < 8.2) (python3.10dist(azure-mgmt-recoveryservices) >= 1 with python3.10dist(azure-mgmt-recoveryservices) < 1.1) (python3.10dist(azure-mgmt-recoveryservicesbackup) >= 0.12 with python3.10dist(azure-mgmt-recoveryservicesbackup) < 0.13) (python3.10dist(azure-mgmt-redis) >= 7~rc1 with python3.10dist(azure-mgmt-redis) < 7.1) (python3.10dist(azure-mgmt-relay) >= 0.1 with python3.10dist(azure-mgmt-relay) < 0.2) (python3.10dist(azure-mgmt-search) >= 8 with python3.10dist(azure-mgmt-search) < 9) (python3.10dist(azure-mgmt-security) >= 0.6 with python3.10dist(azure-mgmt-security) < 0.7) (python3.10dist(azure-mgmt-servicebus) >= 6 with python3.10dist(azure-mgmt-servicebus) < 6.1) (python3.10dist(azure-mgmt-servicefabric) >= 0.5 with python3.10dist(azure-mgmt-servicefabric) < 0.6) (python3.10dist(azure-mgmt-servicefabricmanagedclusters) >= 1 with python3.10dist(azure-mgmt-servicefabricmanagedclusters) < 1.1) (python3.10dist(azure-mgmt-signalr) >= 1~b2 with python3.10dist(azure-mgmt-signalr) < 1.1) (python3.10dist(azure-mgmt-sql) >= 0.29 with python3.10dist(azure-mgmt-sql) < 0.30) (python3.10dist(azure-mgmt-sqlvirtualmachine) >= 0.5 with python3.10dist(azure-mgmt-sqlvirtualmachine) < 0.6) (python3.10dist(azure-mgmt-storage) >= 18 with python3.10dist(azure-mgmt-storage) < 18.1) (python3.10dist(azure-mgmt-synapse) >= 2 with python3.10dist(azure-mgmt-synapse) < 2.1) (python3.10dist(azure-mgmt-trafficmanager) >= 0.51 with python3.10dist(azure-mgmt-trafficmanager) < 0.52) (python3.10dist(azure-mgmt-web) >= 2 with python3.10dist(azure-mgmt-web) < 2.1) (python3.10dist(azure-multiapi-storage) >= 0.6.2 with python3.10dist(azure-multiapi-storage) < 0.7) (python3.10dist(azure-storage-common) >= 1.4 with python3.10dist(azure-storage-common) < 2) (python3.10dist(azure-synapse-accesscontrol) >= 0.5 with python3.10dist(azure-synapse-accesscontrol) < 0.6) (python3.10dist(azure-synapse-artifacts) >= 0.6 with python3.10dist(azure-synapse-artifacts) < 0.7) (python3.10dist(azure-synapse-spark) >= 0.2 with python3.10dist(azure-synapse-spark) < 0.3) (python3.10dist(jsmin) >= 2.2.2 with python3.10dist(jsmin) < 2.3) (python3.10dist(pynacl) >= 1.4 with python3.10dist(pynacl) < 1.5) (python3.10dist(xmltodict) >= 0.12 with python3.10dist(xmltodict) < 1) /usr/bin/python3 python(abi) python3.10dist(antlr4-python3-runtime) python3.10dist(azure-cli-core) python3.10dist(azure-identity) python3.10dist(azure-keyvault-administration) python3.10dist(azure-mgmt-advisor) python3.10dist(azure-mgmt-billing) python3.10dist(azure-mgmt-cdn) python3.10dist(azure-mgmt-containerregistry) python3.10dist(azure-mgmt-eventgrid) python3.10dist(azure-mgmt-iothub) python3.10dist(azure-mgmt-keyvault) python3.10dist(azure-mgmt-marketplaceordering) python3.10dist(azure-mgmt-redhatopenshift) python3.10dist(azure-mgmt-reservations) python3.10dist(azure-mgmt-resource) python3.10dist(fabric) python3.10dist(javaproperties) python3.10dist(jsondiff) python3.10dist(packaging) python3.10dist(pygithub) python3.10dist(pytz) python3.10dist(scp) python3.10dist(semver) python3.10dist(sshtunnel) python3.10dist(websocket-client) python3-azure-cli-core (rpmlib, GLIBC filtered): (python3.10dist(adal) >= 1.2.7 with python3.10dist(adal) < 1.3) (python3.10dist(argcomplete) >= 1.8 with python3.10dist(argcomplete) < 2) (python3.10dist(azure-cli-telemetry) >= 1.0.6 with python3.10dist(azure-cli-telemetry) < 1.0.7) (python3.10dist(azure-common) >= 1.1 with python3.10dist(azure-common) < 2) (python3.10dist(azure-mgmt-core) < 1.3 with python3.10dist(azure-mgmt-core) >= 1.2) (python3.10dist(humanfriendly) < 10 with python3.10dist(humanfriendly) >= 4.7) (python3.10dist(knack) >= 0.8.2 with python3.10dist(knack) < 0.9) (python3.10dist(msal) < 2 with python3.10dist(msal) >= 1.10) (python3.10dist(paramiko) < 3 with python3.10dist(paramiko) >= 2.0.8) (python3.10dist(psutil) >= 5.8 with python3.10dist(psutil) < 6) (python3.10dist(requests) >= 2.26 with python3.10dist(requests) < 3) (python3.10dist(six) >= 1.12 with python3.10dist(six) < 2) python(abi) python3.10dist(cryptography) python3.10dist(jmespath) python3.10dist(pkginfo) python3.10dist(pyjwt) python3.10dist(pyopenssl) python3.10dist(urllib3) python3-azure-cli-telemetry (rpmlib, GLIBC filtered): (python3.10dist(applicationinsights) < 0.12 with python3.10dist(applicationinsights) >= 0.11.1) python(abi) python3.10dist(portalocker) python3-azure-cli-testsdk (rpmlib, GLIBC filtered): python(abi) python3.10dist(azure-devtools) python3.10dist(jmespath) python3.10dist(mock) python3.10dist(pytest) python3.10dist(vcrpy) Provides -------- azure-cli: azure-cli python3.10dist(azure-cli) python3dist(azure-cli) python3-azure-cli-core: python-azure-cli-core python3-azure-cli-core python3.10-azure-cli-core python3.10dist(azure-cli-core) python3dist(azure-cli-core) python3-azure-cli-telemetry: python-azure-cli-telemetry python3-azure-cli-telemetry python3.10-azure-cli-telemetry python3.10dist(azure-cli-telemetry) python3dist(azure-cli-telemetry) python3-azure-cli-testsdk: python-azure-cli-testsdk python3-azure-cli-testsdk python3.10-azure-cli-testsdk python3.10dist(azure-cli-testsdk) python3dist(azure-cli-testsdk) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1986602 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, SugarActivity, PHP, Haskell, R, Ocaml, C/C++, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
