[Bug 1988952] Review Request: CSFML - C bindings for the C++ SFML library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1988952

Petr Menšík <pemensik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |pemensik@xxxxxxxxxx



--- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> ---
Just few notes yet:

I think lowercase package name should be used. It is preferred and does not
make sense to have upper case C binding, when nobody can mix it with common
word.

I would recommend including first number of library so version in non-devel
package instead of %{_libdir}/*.so.*. Helps on later rebases to protect against
ABI breaking updates without dependencies rebuilt.

Otherwise looks ready for formal review. Later :)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux