https://bugzilla.redhat.com/show_bug.cgi?id=1989943 --- Comment #2 from Amirerfan Rafati <aerfanr@xxxxxxxxx> --- (In reply to Gustavo Costa from comment #1) > Hi Amirerfan. I'm not a packager yet, but I have some things to point out > about your spec file: > > * Use a more descriptive Source0 > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > * You can install the README.md as a document file > > %doc README.md > > * Bogus date in %changelog (should be Wednesday instead of Tuesday) > > * Wed Aug 04 2021 Amirerfan Rafati <aerfanr@xxxxxxxxx> - 1.9.0-1 > > Also, use a direct link for your SRPM, like this: > > SRPM URL: > https://download.copr.fedorainfracloud.org/results/aerfanr/birdtray/fedora- > rawhide-x86_64/02362872-birdtray/birdtray-1.9.0-1.fc35.src.rpm Hello there. Thank you for your response. I have considered your points and applied necessary modifications. The only concern is that there is a build section in the README.md file. According to Fedora Packaging guide, we should not include build instructors. It also includes installation instructions for Microsoft Windows. What should I do about that? Should I include the README.MD as is or should I ask upstream to create a separate documentation for Linux without the build instructions? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
