https://bugzilla.redhat.com/show_bug.cgi?id=1989943 Gustavo Costa <xfgusta@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xfgusta@xxxxxxxxx --- Comment #1 from Gustavo Costa <xfgusta@xxxxxxxxx> --- Hi Amirerfan. I'm not a packager yet, but I have some things to point out about your spec file: * Use a more descriptive Source0 Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz * You can install the README.md as a document file %doc README.md * Bogus date in %changelog (should be Wednesday instead of Tuesday) * Wed Aug 04 2021 Amirerfan Rafati <aerfanr@xxxxxxxxx> - 1.9.0-1 Also, use a direct link for your SRPM, like this: SRPM URL: https://download.copr.fedorainfracloud.org/results/aerfanr/birdtray/fedora-rawhide-x86_64/02362872-birdtray/birdtray-1.9.0-1.fc35.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
