https://bugzilla.redhat.com/show_bug.cgi?id=1982210 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- Those are my findings for 0.97-0.1.git01d8563.fc34. I guess thew will also apply for 0.98: URL and Source0 addresses are usable. Ok. TODO: Update URL to <https://shutter-project.org/>. This is where a redirection ends. Source0 archive is original (SHA512: 546df7dec648300d19f56684c6a0fbd377fec56d457d97dcb0527a779e19a6d49e14a7771bacb773cbfdc1b4a067b67825f790defd367e27d945692869c2a2ae). Ok. Summary is Ok. Description is Ok. TODO: I recommend you to use a description from bin/shutter POD or About section at the home page. License verified from README, share/appdata/shutter.appdata.xml, share/shutter/resources/icons/draw.svg, share/shutter/resources/system/upload_plugins/upload/vgyme.pm etc. FIX: Declare all these licenses: FIX: share/shutter/resources/icons/draw.svg packaged is CC-BY-SA FIX: share/shutter/resources/system/plugins/perl/spwatermark/spwatermark.svg is Public Domain FIX: share/shutter/resources/po/shutter/zh_TW.po is MIT (same as gscrot <https://github.com/gscrot/gscrot/blob/master/LICENSE.md>) FIX: share/shutter/resources/icons/drawing_tool/objects/tux.svg is GPLv2 FIX: share/appdata/shutter.appdata.xml is CC0 FIX: The software bundles Tango icons (tango-icon-theme package). You should unbundle them, or declare "Provides: bundled(tango-icon-theme)". See <https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling>. All the icons consume 7 MB. That's pretty wasteful. FIX: Do not use %filter_provides_in. Use %__provides_exclude_from (https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/). FIX: Build-require libappstream-glib (shutter.spec:101). FIX: Build-require coreutils s(shutter.spec:61). FIX: Build-require sed (shutter.spec:64). $ rpmlint shutter.spec ../SRPMS/shutter-0.97-0.1.git01d8563.fc35.src.rpm ../RPMS/noarch/shutter-0.97-0.1.git01d8563.fc35.noarch.rpm ========================================================== rpmlint session starts ========================================================= rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 shutter.noarch: E: wrong-icon-size /usr/share/icons/hicolor/24x24/apps/shutter-panel.png expected: 24x24 actual: 32x32 shutter.noarch: E: wrong-icon-size /usr/share/icons/hicolor/24x24/apps/shutter.png expected: 24x24 actual: 32x32 shutter.noarch: W: no-manual-page-for-binary shutter shutter.noarch: E: invalid-lc-messages-dir /usr/share/locale/ber/LC_MESSAGES/shutter.mo shutter.noarch: E: files-duplicated-waste 416318 shutter.noarch: W: files-duplicate /usr/share/icons/HighContrast/scalable/apps/shutter.svg /usr/share/icons/HighContrast/scalable/apps/shutter-panel.svg shutter.noarch: W: files-duplicate /usr/share/icons/hicolor/16x16/apps/shutter.png /usr/share/icons/hicolor/16x16/apps/shutter-panel.png shutter.noarch: W: files-duplicate /usr/share/icons/hicolor/22x22/apps/shutter.png /usr/share/icons/hicolor/22x22/apps/shutter-panel.png shutter.noarch: W: files-duplicate /usr/share/icons/hicolor/24x24/apps/shutter.png /usr/share/icons/hicolor/24x24/apps/shutter-panel.png shutter.noarch: W: files-duplicate /usr/share/pixmaps/shutter.png /usr/share/icons/hicolor/48x48/apps/shutter.png shutter.noarch: W: files-duplicate /usr/share/icons/hicolor/scalable/apps/shutter.svg /usr/share/icons/hicolor/scalable/apps/shutter-panel.svg shutter.noarch: W: files-duplicate /usr/share/shutter/resources/icons/drawing_tool/draw-image.svg /usr/share/shutter/resources/icons/Image.svg shutter.noarch: W: files-duplicate /usr/share/shutter/resources/icons/drawing_tool/objects/Cursors/Normal.cur /usr/share/shutter/resources/icons/Normal.cur shutter.noarch: W: files-duplicate /usr/share/shutter/resources/icons/drawing_tool/cursor/text /usr/share/shutter/resources/icons/drawing_tool/cursor/backtext shutter.noarch: W: files-duplicate /usr/share/shutter/resources/icons/sel_window_tooltip.svg /usr/share/shutter/resources/icons/drawing_tool/objects/Tango icon library/Apps/internet-group-chat.svg shutter.noarch: W: files-duplicate /usr/share/shutter/resources/icons/drawing_tool/objects/Tango icon library/Status/folder-visiting.icon /usr/share/shutter/resources/icons/drawing_tool/objects/Tango icon library/Status/folder-drag-accept.icon shutter.noarch: E: explicit-lib-dependency libwnck3 ========================== 2 packages and 1 specfiles checked; 5 errors, 12 warnings, 5 badness; has taken 0.9 s ========================== rpmlint is not Ok. FIX: Move the two icons into the correct directory. FIX: Symlink the duplicated files. File layout and permissions are Ok. I will examine the new version and RPM run-time dependencies later. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
