https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #11 from Neal Gompa <ngompa13@xxxxxxxxx> --- Looking over the spec... > %if ! 0%{?gobuild:1} || 0%{?centos} Use %rhel instead of %centos > %define download_url %{git0}/archive/%{built_tag}.tar.gz Use "%{git0}/archive/%{built_tag}/%{name}-%{built_tag_strip}.tar.gz" > Version: 1.21.0 You have a %built_tag_strip variable that you should probably have using this value > %if 0%{?fedora} || 0%{?centos} >= 8 Use %rhel instead of %centos > %if 0%{?centos} <= 7 || 0%{?rhel} <= 7 Use "%if 0%{?rhel} && 0%{?rhel} < 8" instead. > %if ! 0%{?fedora} && (0%{?centos} <= 7 || 0%{?rhel} <= 7) Use "%if 0%{?rhel} && 0%{?rhel} < 8" instead. > %postun > rm -f %{_unitdir}/%{repo}.service This is not acceptable in a scriptlet. Please drop that. > #define license tag if not already defined > %{!?_licensedir:%global license %doc} This is not needed for any supported Fedora or RHEL release. Please drop it. > %{_usr}/lib/sysctl.d/99-cri-o.conf Use "%{_sysctldir}/99-cri-o.conf" instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
