[Bug 1982772] Review Request: ndppd - NDP Proxy Daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1982772

Petr Menšík <pemensik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> ---
Okay, I admit you are correct. All my packages with service files do not
require systemd explicitly nor own %_unitdir directory themselves. I haven't
found any mention about it in guidelines.

Maybe it is okay, according to
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/:
- the directory belongs to your package and does not belong to any core package
or base filesystem package that is considered essential/fundamental to any
Fedora System.

I am pretty sure systemd IS core package. I think it should provide
systemd-filesystem owning just empty %_unitdir, %_userunitdir and %_tmpfilesdir
to avoid unnecessary warnings. Not to be solved for your package however.

Because those were the only issues found, giving review+. Thanks for your
package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux