https://bugzilla.redhat.com/show_bug.cgi?id=1985573 Lukáš Zaoral <lzaoral@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lzaoral@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Lukáš Zaoral <lzaoral@xxxxxxxxxx> --- Hi David, note, that I'm not a member of the packager group yet and this is one of the reviews I have to write to become one. Therefore, some of my suggestions or remarks may not be perfect. Thank you for understanding and patience until some official member responds to your review request (and reviews my review). The spec file looks great! I have only two remarks: * No license file is installed or present in the sources. From guidelines: "If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake." See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. * Just a nitpick: It may be useful to replace all occurrences of qpress by %{name} and 11 by %{version}, e.g. %{name}-%{version}-source.zip. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
