[Bug 332861] Review Request: xmlgraphics-commons - library of components used by batik and fop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmlgraphics-commons - library of components used by batik and fop


https://bugzilla.redhat.com/show_bug.cgi?id=332861





------- Additional Comments From fitzsim@xxxxxxxxxx  2007-11-22 15:21 EST -------
%define section   free

The top two lines should be deleted.

# Move jars existing jars out of the way

Can you just delete them?

ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
#
install -d -m 755 $RPM_BUILD_ROOT%{_javadocdir}/%{name}-%{version}

Stray #.

ln -s %{name}-%{version} $RPM_BUILD_ROOT%{_javadocdir}/%{name} # ghost symlink

That comment should be deleted -- this is no longer a ghost symlink since it
ships with the package.

%doc LICENSE

Also include NOTICE and README on this line.

%ghost %doc %{_javadocdir}/%{name}

This line is no longer necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]