https://bugzilla.redhat.com/show_bug.cgi?id=1981996 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Karolina Surma from comment #1) > package is APPROVED. See detailed results below. Thank you! > Just a nitpick: the patch is justified, which is great, and it could be > mentioned that the changes are present also in upstream, so that it's clear > it's not a downstream-only patch forever. Okay, I have added a comment in my copy of the spec file. > As with the pytest-datadir, I had a prepared specfile using the new > pyproject macros. During my run there are three tests that fail in %check. > Funnily enough, someone has already reported the same failing tests in the > upstream issue: https://github.com/ESSS/pytest-regressions/issues/61 > (specifically those in file `test_dataframe_regression.py`). > When looking at the results, the problem is that regex doesn't match the > expected output. When you look at the test code, you see there are two space > characters at the beginning of the expected output, that are not present in > the actual project code. So it seems the tests actually should fail - but in > your build they all repeatedly pass. > I was trying to find out why two set of macros produce different results, > but failed in this quest. Do you happen to have any idea what could've > happened here? Huh, that's odd. I don't know why that would happen, but I will dig into it and see if I can figure it out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
