https://bugzilla.redhat.com/show_bug.cgi?id=1985116 Lukáš Zaoral <lzaoral@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lzaoral@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Lukáš Zaoral <lzaoral@xxxxxxxxxx> --- Hi Davide, note, that I'm not a member of the packager group yet and this is one of the reviews I've to write to become one. Therefore, some of my suggestions or remarks may not be perfect. Thank you for understanding and patience until some official member responds to your review request (and reviews my review). * SRPM contains some files that are also under different licenses than BSD (e.g. BSD with 2 or 3 clauses) as specified in the spec file. `licensecheck` also found some files licensed under GPL and BSD 4-clause. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/. * `wildmatch` package doesn't install any LICENSE file. * `wildmatch-devel` should contain following requires declaration: `Requires: %{name}%{?_isa} = %{version}-%{release}` (the `%{?_isa}` part is missing). See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package. * I see that you manually add so-name version to the libraries. You have to contact upstream, if you haven't already done so, to upstream this change. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning. * It might also be worth to get in touch with upstream to port the `CMakeLists.txt` to newer version to fix the following warning so that the package will build with future CMake releases without any problems: `Compatibility with CMake < 2.8.12 will be removed from a future version of CMake` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
