https://bugzilla.redhat.com/show_bug.cgi?id=1985357 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Source is 404, it is missinga v before %{version} Source0: %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz - Capitalize the summary - Although the SPEC is working, it is using the former Python guidelines. Please read up on the Python guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ %bcond_without tests %global pypi_name scikit-uplift %global short_name sklift %global pretty_name scikit_uplift %global _description %{expand: scikit-uplift (sklift) is an uplift modeling python package that provides fast sklearn-style models implementation, evaluation metrics and visualization tools. Uplift modeling estimates a causal effect of treatment and uses it to effectively target customers that are most likely to respond to a marketing campaign.} Name: python-%{pypi_name} Version: 0.3.2 Release: 1%{?dist} Summary: Uplift modeling in scikit-learn style in python License: MIT URL: https://github.com/maks-sh/scikit-uplift Source0: %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz BuildArch: noarch BuildRequires: python3-devel %description %_description %package -n python3-%{pypi_name} Summary: %{summary} %description -n python3-%{pypi_name} %_description %package -n python-%{pypi_name}-doc Summary: Scikit-uplift documentation %description -n python-%{pypi_name}-doc Documentation for scikit-uplift package %prep %autosetup -n %{pypi_name}-%{version} # Remove bundled egg-info rm -rf %{pypi_name}.egg-info %generate_buildrequires # No setup.cfg, tox.ini or pyproject.toml echo 'python3dist(pip) >= 19' echo 'python3dist(packaging)' echo 'python3dist(setuptools) >= 40.8' echo 'python3dist(wheel)' echo 'python3dist(sphinx)' echo 'python3dist(recommonmark)' echo 'python3dist(sphinxcontrib-bibtex)' echo 'python3dist(sphinx-rtd-theme)' echo 'python3dist(pytest)' echo 'python3dist(scikit-learn)' echo 'python3dist(pandas)' %build %pyproject_wheel # generate html docs PYTHONPATH=${PWD} sphinx-build-3 docs html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo} %install %pyproject_install # Remove extra install files rm -rf %{buildroot}/%{python3_sitelib}/tests %pyproject_save_files %{short_name} %check %if %{with tests} # Disable network tests %pytest -k 'not test_fetch_hillstrom and not test_fetch_criteo10 and not test_return_X_y_t' %endif %files -n python3-%{pypi_name} -f %{pyproject_files} %license LICENSE %doc Readme.rst %files -n python-%{pypi_name}-doc %doc html %doc notebooks/ %license LICENSE %changelog * Fri Jul 23 2021 Iztok Fister Jr. <iztokf AT fedoraproject DOT org> - 0.3.2-1 - Initial package Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 117 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-scikit-uplift/review-python-scikit- uplift/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-scikit-uplift [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-scikit-uplift-0.3.2-1.fc35.noarch.rpm python-scikit-uplift-doc-0.3.2-1.fc35.noarch.rpm python-scikit-uplift-0.3.2-1.fc35.src.rpm python3-scikit-uplift.noarch: W: summary-not-capitalized C uplift modeling in scikit-learn style in python python3-scikit-uplift.noarch: W: spelling-error %description -l en_US sklearn -> learn python-scikit-uplift-doc.noarch: W: summary-not-capitalized C scikit-uplift documentation python-scikit-uplift.src: W: summary-not-capitalized C uplift modeling in scikit-learn style in python python-scikit-uplift.src: W: spelling-error %description -l en_US sklift -> forklift python-scikit-uplift.src: W: spelling-error %description -l en_US sklearn -> learn 3 packages and 0 specfiles checked; 0 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
