https://bugzilla.redhat.com/show_bug.cgi?id=1983601 --- Comment #4 from Christopher Engelhard <ce@xxxxxxx> --- Looking good! Just two more things: - the %files section is missing %dir %{_datadir}/guile/site/%{mver} (/usr/share/guile/site/3.0 still has no owner) - your patch for the chroot thing seems to be replacing the chroot() call with chdir() instead of doing chdir-then-chroot, is that intended? It would also be OK to leave it unpatched for now and just report the issue upstream. Regarding the tests, it did some more runs and it is all a bit inconsitent for me as well, there were also irreproducible issues with the stack overflow tests that were most likely caused by that test just eating way too much memory. Could be that that also happens for the guile-compile test. Anyway, disabling those inconsistently failing tests if it happens again is perfectly fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
