https://bugzilla.redhat.com/show_bug.cgi?id=1984419 --- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- One extra thing I figured after the review: The package currently has no runtime requires. But it might have some in the future. And since you run tests in %check, I recommend using %pyproject_buildrequires with -r (for runtime). That way, missing runtime requirements won't fail the tests in weird ways in the future and you'll also have a better build failure in case the new dependency is not available in Fedora yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
