Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-enum - Robust enumerated type support in Python https://bugzilla.redhat.com/show_bug.cgi?id=395651 tim.lauridsen@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tim.lauridsen@xxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tim.lauridsen@xxxxxxxxxxxxxx 2007-11-22 08:55 EST ------- I will review this tomorrow, but i have some prelimynary comments. Just write the what the package does in the decription in the spec, not how it does it. That info should be placed in some DOCS. for F8 you have to use BuildRequires: python-setuptools-devel Something like this will work. %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review